This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
Cloudwatch alarm support #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtan4
reviewed
Sep 20, 2016
| end | ||
|
|
||
| def add_checksummed_attributes(attributes, alarm) | ||
| ["insufficient_data_actions", "alarm_actions", "ok_actions", "dimensions"].each do |action| |
There was a problem hiding this comment.
[rubocop]
- Use
%wor%Wfor an array of words. :ref
dtan4
reviewed
Sep 20, 2016
| attribute.each do |attr| | ||
| if attr.is_a? String | ||
| checksum = Zlib.crc32(attr) | ||
| value = attr |
There was a problem hiding this comment.
[rubocop]
- Trailing whitespace detected. :ref
dtan4
reviewed
Sep 20, 2016
| alarm_actions: ["arn:aws:sns:region:account:lambda-alerts"], | ||
| alarm_name: "Alarm With Dimensions", | ||
| comparison_operator: "GreaterThanOrEqualToThreshold", | ||
| dimensions: [ {name: "FunctionName", value: "beep-beep"} ], |
eredi93
force-pushed
the
js/Cloudwatch_alarm_support
branch
from
eb9acf1 to
07959af
Compare
eredi93
force-pushed
the
js/Cloudwatch_alarm_support
branch
from
07959af to
13a2ec4
Compare
1 similar comment
|
LGTM 👍 Thanks ❗ |
|
thanks ✋ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i refactored #182 as i saw no activity on it.
Hope you can merge it in 😄