Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliasing safe_load to load #1

Merged
merged 6 commits into from
Jan 23, 2013
Merged

Aliasing safe_load to load #1

merged 6 commits into from
Jan 23, 2013

Conversation

btoews
Copy link
Contributor

@btoews btoews commented Jan 22, 2013

  • Aliasing YAML::safe_load to YAML::load.
  • Adding orig_load, orig_load_file for original functionality

There are so few use cases for unmarshaling ruby objects with YAML that we should make the "safe" behavior default.

@dtao
Copy link
Owner

dtao commented Jan 23, 2013

I like this idea—esp. as it makes this gem particularly useful for projects where YAML.load might already be used in some places. Just add a dependency on "safe_yaml" and you're done: no more arbitrary code execution vulnerability.

The only thing I'd change is the name 'orig_load'; I think something like 'unsafe_load' would be clearer. I'll merge this for now; but what are your thoughts on that?

dtao added a commit that referenced this pull request Jan 23, 2013
Aliasing `safe_load` to `load`
@dtao dtao merged commit 0392b99 into dtao:master Jan 23, 2013
ota42y pushed a commit to ota42y/safe_yaml that referenced this pull request Aug 14, 2017
…-variable

Feature/build from environment variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants