do not call signal-unsafe function inside sighanlder

die() calls vprintf, fputc and exit; none of these are async-signal-safe, see `man 7 signal-safety`.
dther · Dec 11, 2023 · f962517 · f962517
1 parent f121575
commit f962517
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/dwm.c b/dwm.c
@@ -1534,6 +1534,8 @@ setup(void)
 	Atom utf8string;
 
 	/* clean up any zombies immediately */
+	if (signal(SIGCHLD, sigchld) == SIG_ERR)
+		die("can't install SIGCHLD handler:");
 	sigchld(0);
 
 	/* init screen */
@@ -1631,8 +1633,6 @@ showhide(Client *c)
 void
 sigchld(int unused)
 {
-	if (signal(SIGCHLD, sigchld) == SIG_ERR)
-		die("can't install SIGCHLD handler:");
 	while (0 < waitpid(-1, NULL, WNOHANG));
 }