This repository has been archived by the owner on Dec 27, 2022. It is now read-only.
support mashup use of env!("varname") #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Published in 0.1.8. |
|
Holy smokes, that was fast! Thanks @dtolnay I may follow up with some things small things like updating the documentation. I was also tempted to improve the macro error messages to be more helpful in understanding what input mashup was looking for but wanted to keep this pull focused. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11
This actually fixes another bug I found unexpected with the stringification of
TokenStream::Literal(...)types the issue above as well. Two birds with one stone. I added test cases to cover my changes. This macro panics if the env var is not present with a hopefully helpful message. I wasn't sure how to cover that in a test case. Rust has#[should_panic]attribute for tests but that's don't panic at runtime not at compile time :)