You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, if the commit that a GitHub action refers to is gone due to a force push, it trips over it. E.g. when dependabot checks for updates for this file, it errors:
...
updater | 2024/04/17 01:39:15 ERROR <job_815812220> Error processing dtolnay/rust-toolchain (Dependabot::SharedHelpers::HelperSubprocessFailed)
updater | 2024/04/17 01:39:15 ERROR <job_815812220> error: no such commit d0592fe69e35bc8f12e3dbaf9ad2694d976cb8e3
...
updater | 2024/04/17 01:39:15 INFO Results:
updater | Dependabot encountered '1' error(s) during execution, please check the logs for more details.
updater | +----------------------------------------+
updater | | Dependencies failed to update |
updater | +------------------------+---------------+
updater | | dtolnay/rust-toolchain | unknown_error |
updater | +------------------------+---------------+
updater | time="2024-04-17T01:39:15Z" level=info msg="task complete" container_id=job-815812220-updater exit_code=0 job_id=815812220 step=updater
One could argue that dependabot shouldn't trip and just pick a new commit, but I think force-pushing to the branch leaves the pinned commit dangling and subject to garbage collection, which would break CI pipelines. So I think my ask is to NOT force push branches at all. This also makes reasoning about changes a bit easier when you look at the Git history.
PS: Other than that the rust-toolchain action works super well. Thank you very much! ❤️
The text was updated successfully, but these errors were encountered:
It's good practice to pin GitHub action via commits instead of tags or branch names.
Dependabot supports this as well.
However, if the commit that a GitHub action refers to is gone due to a force push, it trips over it. E.g. when dependabot checks for updates for this file, it errors:
One could argue that dependabot shouldn't trip and just pick a new commit, but I think force-pushing to the branch leaves the pinned commit dangling and subject to garbage collection, which would break CI pipelines. So I think my ask is to NOT force push branches at all. This also makes reasoning about changes a bit easier when you look at the Git history.
PS: Other than that the
rust-toolchain
action works super well. Thank you very much! ❤️The text was updated successfully, but these errors were encountered: