Http progress event fix #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
borntocompile
commented
Aug 17, 2019
borntocompile
commented
- onProgress now uses null propagation before invoking.
- onProgress now invoke with the correct value as a parameter
* onProgress now uses null propagation before invoking. * onProgress now invoke with the correct value as a parameter
borntocompile
requested review from
phil-allcock,
FancySensei,
kkjamie,
zieglerkevin,
danhalldubit and
SlaveykoSlaveykov-Dubit
borntocompile
commented
Aug 17, 2019
| @@ -125,8 +125,7 @@ private void UpdateProgress(ref float currentProgress, float progress, Action<fl | |||
| { | |||
| if (currentProgress < progress) | |||
| { | |||
| currentProgress = progress; | |||
| onProgress(downloadProgress); | |||
| onProgress?.Invoke(currentProgress = progress); | |||
There was a problem hiding this comment.
With the assigning of currentProgress happening in the invocation does this mean it wont be assigned if onProgress event is null? if so then this would be incorrect functionality.
Moved the assigning of currentProgress out of the invokation of the onProgress event
danhalldubit
approved these changes
Sep 1, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.