Skip to content

Commit

Permalink
✅ Move to v8 for coverage (#4873)
Browse files Browse the repository at this point in the history
Instanbul used to be the default when we relied on Jest. V8 having its
own coverage measurements, we are trying to move to it and to see how
much it will impact our coverage.
  • Loading branch information
dubzzz authored Apr 7, 2024
1 parent 154e195 commit b32afae
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 10 deletions.
8 changes: 8 additions & 0 deletions .yarn/versions/4949103f.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
releases:
fast-check: patch

declined:
- "@fast-check/ava"
- "@fast-check/jest"
- "@fast-check/vitest"
- "@fast-check/worker"
2 changes: 1 addition & 1 deletion packages/fast-check/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"@fast-check/poisoning": "workspace:*",
"@microsoft/api-extractor": "^7.43.0",
"@types/node": "^20.12.5",
"@vitest/coverage-istanbul": "^1.4.0",
"@vitest/coverage-v8": "^1.4.0",
"cross-env": "^7.0.3",
"glob": "^10.3.12",
"not-node-buffer": "npm:buffer@^6.0.3",
Expand Down
1 change: 0 additions & 1 deletion packages/fast-check/vitest.unit.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export default defineConfig({
enabled: true,
include: ['src/**'],
exclude: ['lib/**', 'test/**'],
provider: 'istanbul',
},
include: ['test/unit/**/*.spec.?(c|m)[jt]s?(x)'],
},
Expand Down
21 changes: 13 additions & 8 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ __metadata:
languageName: node
linkType: hard

"@ampproject/remapping@npm:^2.2.0":
"@ampproject/remapping@npm:^2.2.0, @ampproject/remapping@npm:^2.2.1":
version: 2.3.0
resolution: "@ampproject/remapping@npm:2.3.0"
dependencies:
Expand Down Expand Up @@ -5597,22 +5597,27 @@ __metadata:
languageName: node
linkType: hard

"@vitest/coverage-istanbul@npm:^1.4.0":
"@vitest/coverage-v8@npm:^1.4.0":
version: 1.4.0
resolution: "@vitest/coverage-istanbul@npm:1.4.0"
resolution: "@vitest/coverage-v8@npm:1.4.0"
dependencies:
"@ampproject/remapping": "npm:^2.2.1"
"@bcoe/v8-coverage": "npm:^0.2.3"
debug: "npm:^4.3.4"
istanbul-lib-coverage: "npm:^3.2.2"
istanbul-lib-instrument: "npm:^6.0.1"
istanbul-lib-report: "npm:^3.0.1"
istanbul-lib-source-maps: "npm:^5.0.4"
istanbul-reports: "npm:^3.1.6"
magic-string: "npm:^0.30.5"
magicast: "npm:^0.3.3"
picocolors: "npm:^1.0.0"
std-env: "npm:^3.5.0"
strip-literal: "npm:^2.0.0"
test-exclude: "npm:^6.0.0"
v8-to-istanbul: "npm:^9.2.0"
peerDependencies:
vitest: 1.4.0
checksum: 10c0/0c1ac9ea86bfd03c06b9a05888daebb9f740b264f307884be200ee4be0026c08d9382d3f470b648cd9602130f1dec27e99e1438d893d6de9b9ecb470db3a8e12
checksum: 10c0/1ff9db69c8f45c9e3f57d513d577331c23748c53d93122889b8634d1997a61a2a37a7284f520b647b837f44150656c1127b9c3392112139224bb86678aae1e7e
languageName: node
linkType: hard

Expand Down Expand Up @@ -9443,7 +9448,7 @@ __metadata:
"@fast-check/poisoning": "workspace:*"
"@microsoft/api-extractor": "npm:^7.43.0"
"@types/node": "npm:^20.12.5"
"@vitest/coverage-istanbul": "npm:^1.4.0"
"@vitest/coverage-v8": "npm:^1.4.0"
cross-env: "npm:^7.0.3"
glob: "npm:^10.3.12"
not-node-buffer: "npm:buffer@^6.0.3"
Expand Down Expand Up @@ -11724,7 +11729,7 @@ __metadata:
languageName: node
linkType: hard

"istanbul-lib-instrument@npm:^6.0.0, istanbul-lib-instrument@npm:^6.0.1":
"istanbul-lib-instrument@npm:^6.0.0":
version: 6.0.2
resolution: "istanbul-lib-instrument@npm:6.0.2"
dependencies:
Expand Down Expand Up @@ -18953,7 +18958,7 @@ __metadata:
languageName: node
linkType: hard

"v8-to-istanbul@npm:^9.0.1":
"v8-to-istanbul@npm:^9.0.1, v8-to-istanbul@npm:^9.2.0":
version: 9.2.0
resolution: "v8-to-istanbul@npm:9.2.0"
dependencies:
Expand Down

0 comments on commit b32afae

Please sign in to comment.