💥 Include invalid dates by default #4490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fc28f52:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next-3_14_0 #4490 +/- ##
============================================
Coverage 93.29% 93.29%
============================================
Files 207 207
Lines 5013 5013
Branches 1355 1354 -1
============================================
Hits 4677 4677
Misses 336 336
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dubzzz
added a commit
that referenced
this pull request
Jan 2, 2024
**💥 Breaking change**
In v3, `fc.date` was not producing "Invalid Date" values by default. One has to specify `noInvalidDate: false` to get some. With this PR we now default the flag to false when not specified: in other words, the new default will be to produce invalid dates except asked explicitly not to.
After that change, if you want not to produce "Invalid Date", you'll have to use:
```js
// in v3, it was only producing valid dates
fc.date()
// equivalent in v4
fc.date({noInvalidDate: true})
//---
// in v3, including invalid dates required users to pass an extra constraint to the arbitrary
fc.date({noInvalidDate: false})
// equivalent in v4
fc.date()
```
You can also prepare yourself to v4 by already toggling: `noInvalidDate: false` on your `fc.date`.
dubzzz
added a commit
that referenced
this pull request
May 16, 2024
**💥 Breaking change**
In v3, `fc.date` was not producing "Invalid Date" values by default. One has to specify `noInvalidDate: false` to get some. With this PR we now default the flag to false when not specified: in other words, the new default will be to produce invalid dates except asked explicitly not to.
After that change, if you want not to produce "Invalid Date", you'll have to use:
```js
// in v3, it was only producing valid dates
fc.date()
// equivalent in v4
fc.date({noInvalidDate: true})
//---
// in v3, including invalid dates required users to pass an extra constraint to the arbitrary
fc.date({noInvalidDate: false})
// equivalent in v4
fc.date()
```
You can also prepare yourself to v4 by already toggling: `noInvalidDate: false` on your `fc.date`.
dubzzz
added a commit
that referenced
this pull request
May 17, 2024
**💥 Breaking change**
In v3, `fc.date` was not producing "Invalid Date" values by default. One has to specify `noInvalidDate: false` to get some. With this PR we now default the flag to false when not specified: in other words, the new default will be to produce invalid dates except asked explicitly not to.
After that change, if you want not to produce "Invalid Date", you'll have to use:
```js
// in v3, it was only producing valid dates
fc.date()
// equivalent in v4
fc.date({noInvalidDate: true})
//---
// in v3, including invalid dates required users to pass an extra constraint to the arbitrary
fc.date({noInvalidDate: false})
// equivalent in v4
fc.date()
```
You can also prepare yourself to v4 by already toggling: `noInvalidDate: false` on your `fc.date`.
dubzzz
added a commit
that referenced
this pull request
May 29, 2024
**💥 Breaking change**
In v3, `fc.date` was not producing "Invalid Date" values by default. One has to specify `noInvalidDate: false` to get some. With this PR we now default the flag to false when not specified: in other words, the new default will be to produce invalid dates except asked explicitly not to.
After that change, if you want not to produce "Invalid Date", you'll have to use:
```js
// in v3, it was only producing valid dates
fc.date()
// equivalent in v4
fc.date({noInvalidDate: true})
//---
// in v3, including invalid dates required users to pass an extra constraint to the arbitrary
fc.date({noInvalidDate: false})
// equivalent in v4
fc.date()
```
You can also prepare yourself to v4 by already toggling: `noInvalidDate: false` on your `fc.date`.
dubzzz
added a commit
that referenced
this pull request
Jul 16, 2024
**💥 Breaking change**
In v3, `fc.date` was not producing "Invalid Date" values by default. One has to specify `noInvalidDate: false` to get some. With this PR we now default the flag to false when not specified: in other words, the new default will be to produce invalid dates except asked explicitly not to.
After that change, if you want not to produce "Invalid Date", you'll have to use:
```js
// in v3, it was only producing valid dates
fc.date()
// equivalent in v4
fc.date({noInvalidDate: true})
//---
// in v3, including invalid dates required users to pass an extra constraint to the arbitrary
fc.date({noInvalidDate: false})
// equivalent in v4
fc.date()
```
You can also prepare yourself to v4 by already toggling: `noInvalidDate: false` on your `fc.date`.
dubzzz
added a commit
that referenced
this pull request
Aug 13, 2024
**💥 Breaking change**
In v3, `fc.date` was not producing "Invalid Date" values by default. One has to specify `noInvalidDate: false` to get some. With this PR we now default the flag to false when not specified: in other words, the new default will be to produce invalid dates except asked explicitly not to.
After that change, if you want not to produce "Invalid Date", you'll have to use:
```js
// in v3, it was only producing valid dates
fc.date()
// equivalent in v4
fc.date({noInvalidDate: true})
//---
// in v3, including invalid dates required users to pass an extra constraint to the arbitrary
fc.date({noInvalidDate: false})
// equivalent in v4
fc.date()
```
You can also prepare yourself to v4 by already toggling: `noInvalidDate: false` on your `fc.date`.
dubzzz
added a commit
that referenced
this pull request
Sep 23, 2024
**💥 Breaking change**
In v3, `fc.date` was not producing "Invalid Date" values by default. One has to specify `noInvalidDate: false` to get some. With this PR we now default the flag to false when not specified: in other words, the new default will be to produce invalid dates except asked explicitly not to.
After that change, if you want not to produce "Invalid Date", you'll have to use:
```js
// in v3, it was only producing valid dates
fc.date()
// equivalent in v4
fc.date({noInvalidDate: true})
//---
// in v3, including invalid dates required users to pass an extra constraint to the arbitrary
fc.date({noInvalidDate: false})
// equivalent in v4
fc.date()
```
You can also prepare yourself to v4 by already toggling: `noInvalidDate: false` on your `fc.date`.
dubzzz
added a commit
that referenced
this pull request
Nov 6, 2024
**💥 Breaking change**
In v3, `fc.date` was not producing "Invalid Date" values by default. One has to specify `noInvalidDate: false` to get some. With this PR we now default the flag to false when not specified: in other words, the new default will be to produce invalid dates except asked explicitly not to.
After that change, if you want not to produce "Invalid Date", you'll have to use:
```js
// in v3, it was only producing valid dates
fc.date()
// equivalent in v4
fc.date({noInvalidDate: true})
//---
// in v3, including invalid dates required users to pass an extra constraint to the arbitrary
fc.date({noInvalidDate: false})
// equivalent in v4
fc.date()
```
You can also prepare yourself to v4 by already toggling: `noInvalidDate: false` on your `fc.date`.
dubzzz
added a commit
that referenced
this pull request
Jan 9, 2025
**💥 Breaking change**
In v3, `fc.date` was not producing "Invalid Date" values by default. One has to specify `noInvalidDate: false` to get some. With this PR we now default the flag to false when not specified: in other words, the new default will be to produce invalid dates except asked explicitly not to.
After that change, if you want not to produce "Invalid Date", you'll have to use:
```js
// in v3, it was only producing valid dates
fc.date()
// equivalent in v4
fc.date({noInvalidDate: true})
//---
// in v3, including invalid dates required users to pass an extra constraint to the arbitrary
fc.date({noInvalidDate: false})
// equivalent in v4
fc.date()
```
You can also prepare yourself to v4 by already toggling: `noInvalidDate: false` on your `fc.date`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💥 Breaking change
In v3,
fc.datewas not producing "Invalid Date" values by default. One has to specifynoInvalidDate: falseto get some. With this PR we now default the flag to false when not specified: in other words, the new default will be to produce invalid dates except asked explicitly not to.After that change, if you want not to produce "Invalid Date", you'll have to use:
You can also prepare yourself to v4 by already toggling:
noInvalidDate: falseon yourfc.date.