Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable union test #340

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

enable union test #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6693513
enable union test
Mause Jun 8, 2024
caa2842
Merge branch 'main' into enable-union-test
Mause Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions crates/duckdb/src/test_all_types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,8 @@ fn test_large_arrow_types() -> crate::Result<()> {
}

fn test_with_database(database: &Connection) -> crate::Result<()> {
// uhugeint, time_tz, and dec38_10 aren't supported in the duckdb arrow layer
// union is currently blocked by https://github.com/duckdb/duckdb/pull/11326
let excluded = ["uhugeint", "time_tz", "dec38_10", "union", "varint"];
// uhugeint, time_tz, varint, and dec38_10 aren't supported in the duckdb arrow layer
let excluded = ["uhugeint", "time_tz", "dec38_10", "varint"];

let mut binding = database.prepare(&format!(
"SELECT * EXCLUDE ({}) FROM test_all_types()",
Expand Down
3 changes: 2 additions & 1 deletion crates/duckdb/src/types/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ impl From<&DataType> for Type {
.collect(),
),
DataType::LargeList(inner) => Self::List(Box::new(Type::from(inner.data_type()))),
// DataType::Union(_, _) => Self::Union,
DataType::Union(_, _) => Self::Union,
DataType::Dictionary(_, _) => Self::Enum,
DataType::Decimal128(..) => Self::Decimal,
DataType::Decimal256(..) => Self::Decimal,
DataType::Map(field, ..) => {
Expand Down
Loading