duckdb-wasm-app: Scope some logic out of React into HTML/CSS #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlopi
force-pushed
the
duckdb-wasm-app
branch
2 times, most recently
from
8350d6f to
929b146
Compare
This fixes some glitches (white space bottom left corner) and allows to sepate concerns between xterm/shell rendering and general navbar rendering. Also adds link to duckdb.org from the duck logo and adds title elements.
carlopi
force-pushed
the
duckdb-wasm-app
branch
from
929b146 to
6ea5e89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #1200 resurrected.
Idea is separating shell.duckdb.org website in 2 separate components: the actual shell is a React component, while the rest of the page will become a static HTML/CSS(/JS?) component.
Main idea is allowing more easily to have a starting point to embed the duckdb-wasm shell in third parties websites.
This is not a complete effort, there are some shortcuts (like assuming a single component per page), but it should be a starting point. If you plan on using this, help is very much welcome.
This fixes some glitches (white space bottom left corner) and allows to separate concerns between xterm/shell rendering and general navbar rendering.
Also adds link to duckdb.org from the duck logo and adds title elements.