AI Chat handoff #3785
Merged
AI Chat handoff #3785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # DuckDuckGo/MainViewController.swift
brindy
requested changes
Jan 14, 2025
| private var payloadHandler = AIChatPayloadHandler() | ||
|
|
||
| @MainActor | ||
| lazy var aiChatViewController: AIChatViewController = { |
Comment on lines
+41
to
+44
| /// Default rule for DuckDuckGo AI Chat | ||
| if let ddgDomain = URL.ddg.host { | ||
| rules.append(.exact(hostname: ddgDomain)) | ||
| } |
There was a problem hiding this comment.
Just acknowledging we discussed this. No action required.
Comment on lines
38
to
39
| let settings = AIChatSettings(privacyConfigurationManager: ContentBlocking.shared.privacyConfigurationManager, | ||
| internalUserDecider: AppDependencyProvider.shared.internalUserDecider) |
There was a problem hiding this comment.
Can we inject these instead? Since this is lazy they should be available by this point.
DuckDuckGo/UserScripts.swift
Outdated
| @@ -66,6 +67,8 @@ final class UserScripts: UserScriptsProvider { | |||
| properties: sourceProvider.contentScopeProperties, | |||
| isIsolated: true) | |||
| autoconsentUserScript = AutoconsentUserScript(config: sourceProvider.privacyConfigurationManager.privacyConfig) | |||
| aiChatUserScript = AIChatUserScript(handler: AIChatUserScriptHandler(featureFlagger: AppDependencyProvider.shared.featureFlagger)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204167627774280/1209119202522826/f
Description:
Add handoff support using the C-S-S communication layer
Steps to test this PR:
This feature depends on some FE changes in the SERP, so to test it you'll need to do a bit of initial setup: