Use E-TLD+1 when matching domain for login saves #3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
amddg44
approved these changes
Feb 11, 2025
graeme
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Feb 12, 2025
<!-- Note: This checklist is a reminder of our shared engineering expectations. --> Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/72649045549333/1209272524872735 iOS PR: duckduckgo/iOS#3943 macOS PR: duckduckgo/macos-browser#3844 What kind of version bump will this require?: Major **Description**: Right now, we will offer to autofill into a page which is considered an E-TLD+1 match. But we aren’t as good at comparing E-TLD+1 when it comes to considering whether to offer to save it or not. We should detect we have a domain saved already and don’t offer to save when entering credentials for an equivalent subdomain This should also apply to other scenarios like offering to update the saved password; we should also consider E-TLD+1 matches **Steps to test this PR**: https://app.asana.com/0/1203822806345703/1209279526650235 <!-- Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you *know* do not need explicit testing. Using a simulator where a physical device is unavailable is acceptable. --> **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1209272524872735
Description:
Right now, we will offer to autofill into a page which is considered an E-TLD+1 match.
But we aren’t as good at comparing E-TLD+1 when it comes to considering whether to offer to save it or not.
We should detect we have a domain saved already and don’t offer to save when entering credentials for an equivalent subdomain
This should also apply to other scenarios like offering to update the saved password; we should also consider E-TLD+1 matches
Steps to test this PR:
https://app.asana.com/0/1203822806345703/1209279526650235
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation