Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix targeted versions for error banner downloads #3859

Merged

Conversation

jotaemepereira
Copy link
Collaborator

@jotaemepereira jotaemepereira commented Feb 11, 2025

Task/Issue URL: https://app.asana.com/0/1201048563534612/1209364376915316
Tech Design URL:
CC:

Description:
It adds macOS 15.0 to the version pool, showing the download error banner.

Steps to test this PR:

  1. Hardcode the currentVersion to 15.0
  2. In WebKitDownloadTask.tempDownloadFileCreated, add some code to throw a NSError with code NSFileReadUnknownError.
  3. Then, try to download a file, it should be fail immediately and show the error banner
  4. You can play with different hardcoded macOS versions to check if the banner is being shown.

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

@alessandroboron alessandroboron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jotaemepereira

I was suggesting to add tests but I can see that the class it doesn’t inject interfaces for its dependencies. Perhaps something we can improve in the future.

@jotaemepereira jotaemepereira merged commit 39a1073 into release/1.126.0 Feb 12, 2025
32 of 38 checks passed
@jotaemepereira jotaemepereira deleted the juan/fix-downloads-error-banner-version branch February 12, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants