Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire NTP initial pixel from HTML New Tab Page #3868

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Feb 14, 2025

Task/Issue URL: https://app.asana.com/0/1201899738287924/1209398104352347

Description:
This change brings back the NTP pixel used for tracking Next Steps cards performance.

Steps to test this PR:

  1. Update MainWindowControler.swift line 83 to return true
  2. Clean app data and launch the app from Xcode
  3. Go through onboarding and verify in the logs that m_mac_new-tab-opened_initial pixel was fired.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

@alessandroboron alessandroboron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested and works as expected!

@ayoy ayoy merged commit 4c172b6 into release/1.126.0 Feb 14, 2025
30 of 32 checks passed
@ayoy ayoy deleted the dominik/add-ntp-initial-pixel branch February 14, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants