fix playwright tests with better mock separation #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for ddgdash ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
NPM npm i github:duckduckgo/privacy-dashboard#f9423fcf11345191d01081770b48cdd9eb53a867Git submodule: git submodule update --remote --init submodules/privacy-dashboard
cd submodules/privacy-dashboard
git fetch origin
git checkout pr-releases/pr-227
git reset --hard origin/pr-releases/pr-227Swift .package(url: "https://github.com/duckduckgo/privacy-dashboard", revision: "f9423fcf11345191d01081770b48cdd9eb53a867"), |
1 task
shakyShane
force-pushed
the
02-09-fix_playwright_tests_with_better_mock_separation
branch
from
8916259 to
11894a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @mgurgel
https://app.asana.com/0/1200835453786799/1209359170590866
Description:
import json from "some.jsonto creep into the test code - this prevents some versions of node from being able to execute the playwright test suite. In particular, it prevented my IDE from being able to run single tests in isolation. So I've made the boundary clearer by moving the browser mocks into a separate fileSteps to test this PR: