handle different arity of type params for interfaces #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! Files to checkThese are files which is affected by the current PR, but not reflected. If there's no file below this message, please ignore this message. You can run |
awareness481
commented
Apr 14, 2023
| (Some(a_tps), Some(b_tps)) => { | ||
| if a_tps.params.len() != b_tps.params.len() { | ||
| self.storage | ||
| .report(ErrorKind::InterfaceNonIdenticalTypeParams { span: a.span() }.into()); |
There was a problem hiding this comment.
span currently looks like this
interface A<T extends string> {}
────────────────────────────────is there any way to only use the span of the name of the interface? (like tsc)
interface A<T extends string> {}
─
There was a problem hiding this comment.
I think we should add a field like name_span to the Interface type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Ref: #956