Implement noCross for darwin #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output of `/sbin/mount` is pretty similar to FreeBSD one. Since its very common to have spaces in paths we handle mount points with spaces as well.
Pull Request Test Coverage Report for Build 1534623471
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 24 24
Lines 2234 2234
=======================================
Hits 2111 2111
Misses 85 85
Partials 38 38 Continue to review full report at Codecov.
|
|
Very nice, thank you! |
|
@dundee I think you might have a bug for mounted points with spaces on Also some duplicated code so probably some refactoring there would help (darwin and freebsd at least) |
|
@inglor You are right, I will fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of
/sbin/mountis pretty similar to FreeBSD one. Since itsvery common to have spaces in paths we handle mount points with spaces
as well.
Fixes: #107