Implement get_latest_result_dataframe helper function #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The get_latest_result implementation parses json, which is slow for large results. The csv endpoint is a lot more efficient, especially if you just need to put the data into a pandas DataFrame. get_latest_result_dataframe is a helper function that calls download_csv and returns a DataFrame from the result.
TheEdgeOfRage
force-pushed
the
latest-result-dataframe
branch
from
2745092 to
686e34f
Compare
msf
reviewed
Oct 10, 2023
| @@ -118,6 +118,27 @@ def get_latest_result( | |||
| except KeyError as err: | |||
| raise DuneError(response_json, "ResultsResponse", err) from err | |||
|
|
|||
| def get_latest_result_dataframe( | |||
There was a problem hiding this comment.
yes, this is a performance improvement for the examples on https://github.com/duneanalytics/dune-client/pull/99/files
msf
approved these changes
Oct 10, 2023
bh2smith
approved these changes
Oct 10, 2023
|
I re-ran the failing test to see if it was just an intermittent failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get_latest_result implementation parses json,
which is slow for large results. The csv endpoint
is a lot more efficient, especially if you just
need to put the data into a pandas DataFrame.
get_latest_result_dataframe is a helper function
that calls download_csv and returns a DataFrame
from the result.