Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Partial to QueryState Enum #125

Merged
merged 6 commits into from
Aug 26, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move the warning log to get_results
bh2smith committed Aug 26, 2024
commit ab6d42d7119700767054a21f94a33180d4c1e571
12 changes: 8 additions & 4 deletions dune_client/api/execution.py
Original file line number Diff line number Diff line change
@@ -22,6 +22,7 @@
ResultsResponse,
ExecutionResultCSV,
DuneError,
ExecutionState,
)
from dune_client.query import QueryBase

@@ -128,9 +129,7 @@ def get_execution_results_csv(
return self._get_execution_results_csv_by_url(url=url, params=params)

def _get_execution_results_by_url(
self,
url: str,
params: Optional[Dict[str, Any]] = None,
self, url: str, params: Optional[Dict[str, Any]] = None, job_id=None
) -> ResultsResponse:
"""
GET results from Dune API with a given URL. This is particularly useful for pagination.
@@ -139,7 +138,12 @@ def _get_execution_results_by_url(

response_json = self._get(url=url, params=params)
try:
return ResultsResponse.from_dict(response_json)
result = ResultsResponse.from_dict(response_json)
if result.state == ExecutionState.PARTIAL:
self.logger.warning(
f"execution {job_id} resulted in a partial result set (i.e. results too large)."
)
return result
except KeyError as err:
raise DuneError(response_json, "ResultsResponse", err) from err

4 changes: 0 additions & 4 deletions dune_client/api/extensions.py
Original file line number Diff line number Diff line change
@@ -421,10 +421,6 @@ def _refresh(
if status.state == ExecutionState.FAILED:
self.logger.error(status)
raise QueryFailed(f"Error data: {status.error}")
if status.state == ExecutionState.PARTIAL:
self.logger.warning(
f"execution {job_id} resulted in a partial result set (i.e. results too large)."
)
return job_id

def _fetch_entire_result(