[Premium Feature] run_sql #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
force-pushed
the
split-client-class
branch
from
1eed668 to
abdc08b
Compare
bh2smith
force-pushed
the
feature_run_sql
branch
2 times, most recently
from
4603c36 to
eeb48ad
Compare
diegoximenes
approved these changes
Sep 7, 2023
|
Approved but e2e-tests are failing though 🤔 |
This is partially because I have no more credits to test with. And also because upload CSV requires premium subscription which I also don't have. |
I will check internally how Dune can give you access to an API key related to a premium subscription :) |
bh2smith
force-pushed
the
split-client-class
branch
from
4567baa to
2aa3ad0
Compare
bh2smith
force-pushed
the
feature_run_sql
branch
from
eeb48ad to
3a96c42
Compare
bh2smith
force-pushed
the
feature_run_sql
branch
from
d1a9e38 to
1a8b7c9
Compare
msf
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77
Adds run_sql method which creates a query, executes, gets results and optionally archives the query (by default).
Test Plan
This can't be tested with any API key that I have. But the test is there (skipped) and pretty straightforward to follow. Given that all the other routes are tested, it should be fine.
cc @TheEdgeOfRage & @diegoximenes for additional review.