Modernize and secure temp file creation

aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSOutputStream.java

@@ -30,6 +30,7 @@
 import java.io.InputStream;
 import java.io.OutputStream;
 import java.io.UncheckedIOException;
+import java.nio.file.Files;
 import java.util.Arrays;
 import org.apache.iceberg.aliyun.AliyunProperties;
 import org.apache.iceberg.exceptions.NotFoundException;
@@ -72,7 +73,7 @@ public class OSSOutputStream extends PositionOutputStream {
 
   private static File newStagingFile(String ossStagingDirectory) {
     try {
-      File stagingFile = File.createTempFile("oss-file-io-", ".tmp", new File(ossStagingDirectory));
+      File stagingFile = Files.createTempFile(new File(ossStagingDirectory).toPath(), "oss-file-io-", ".tmp").toFile();
       stagingFile.deleteOnExit();
       return stagingFile;
     } catch (IOException e) {

aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java

@@ -216,7 +216,7 @@ private void newStream() throws IOException {
     }
 
     createStagingDirectoryIfNotExists();
-    currentStagingFile = File.createTempFile("s3fileio-", ".tmp", stagingDirectory);
+    currentStagingFile = Files.createTempFile(stagingDirectory.toPath(), "s3fileio-", ".tmp").toFile();
     currentStagingFile.deleteOnExit();
     try {
       currentPartMessageDigest =

spark/v3.2/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetReadersFlatDataBenchmark.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.spark.data.parquet;
 
+import java.nio.file.Files;
 import static org.apache.iceberg.types.Types.NestedField.optional;
 import static org.apache.iceberg.types.Types.NestedField.required;
 
@@ -93,7 +94,7 @@ public class SparkParquetReadersFlatDataBenchmark {
 
   @Setup
   public void setupBenchmark() throws IOException {
-    dataFile = File.createTempFile("parquet-flat-data-benchmark", ".parquet");
+    dataFile = Files.createTempFile("parquet-flat-data-benchmark", ".parquet").toFile();
     dataFile.delete();
     List<GenericData.Record> records = RandomData.generateList(SCHEMA, NUM_RECORDS, 0L);
     try (FileAppender<GenericData.Record> writer =

spark/v3.2/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetReadersNestedDataBenchmark.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.spark.data.parquet;
 
+import java.nio.file.Files;
 import static org.apache.iceberg.types.Types.NestedField.optional;
 import static org.apache.iceberg.types.Types.NestedField.required;
 
@@ -91,7 +92,7 @@ public class SparkParquetReadersNestedDataBenchmark {
 
   @Setup
   public void setupBenchmark() throws IOException {
-    dataFile = File.createTempFile("parquet-nested-data-benchmark", ".parquet");
+    dataFile = Files.createTempFile("parquet-nested-data-benchmark", ".parquet").toFile();
     dataFile.delete();
     List<GenericData.Record> records = RandomData.generateList(SCHEMA, NUM_RECORDS, 0L);
     try (FileAppender<GenericData.Record> writer =

spark/v3.2/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetWritersFlatDataBenchmark.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.spark.data.parquet;
 
+import java.nio.file.Files;
 import static org.apache.iceberg.types.Types.NestedField.optional;
 import static org.apache.iceberg.types.Types.NestedField.required;
 
@@ -81,7 +82,7 @@ public class SparkParquetWritersFlatDataBenchmark {
   @Setup
   public void setupBenchmark() throws IOException {
     rows = RandomData.generateSpark(SCHEMA, NUM_RECORDS, 0L);
-    dataFile = File.createTempFile("parquet-flat-data-benchmark", ".parquet");
+    dataFile = Files.createTempFile("parquet-flat-data-benchmark", ".parquet").toFile();
     dataFile.delete();
   }
 

spark/v3.2/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetWritersNestedDataBenchmark.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.spark.data.parquet;
 
+import java.nio.file.Files;
 import static org.apache.iceberg.types.Types.NestedField.optional;
 import static org.apache.iceberg.types.Types.NestedField.required;
 
@@ -81,7 +82,7 @@ public class SparkParquetWritersNestedDataBenchmark {
   @Setup
   public void setupBenchmark() throws IOException {
     rows = RandomData.generateSpark(SCHEMA, NUM_RECORDS, 0L);
-    dataFile = File.createTempFile("parquet-nested-data-benchmark", ".parquet");
+    dataFile = Files.createTempFile("parquet-nested-data-benchmark", ".parquet").toFile();
     dataFile.delete();
   }
 

spark/v3.3/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetReadersFlatDataBenchmark.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.spark.data.parquet;
 
+import java.nio.file.Files;
 import static org.apache.iceberg.types.Types.NestedField.optional;
 import static org.apache.iceberg.types.Types.NestedField.required;
 
@@ -93,7 +94,7 @@ public class SparkParquetReadersFlatDataBenchmark {
 
   @Setup
   public void setupBenchmark() throws IOException {
-    dataFile = File.createTempFile("parquet-flat-data-benchmark", ".parquet");
+    dataFile = Files.createTempFile("parquet-flat-data-benchmark", ".parquet").toFile();
     dataFile.delete();
     List<GenericData.Record> records = RandomData.generateList(SCHEMA, NUM_RECORDS, 0L);
     try (FileAppender<GenericData.Record> writer =

spark/v3.3/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetReadersNestedDataBenchmark.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.spark.data.parquet;
 
+import java.nio.file.Files;
 import static org.apache.iceberg.types.Types.NestedField.optional;
 import static org.apache.iceberg.types.Types.NestedField.required;
 
@@ -91,7 +92,7 @@ public class SparkParquetReadersNestedDataBenchmark {
 
   @Setup
   public void setupBenchmark() throws IOException {
-    dataFile = File.createTempFile("parquet-nested-data-benchmark", ".parquet");
+    dataFile = Files.createTempFile("parquet-nested-data-benchmark", ".parquet").toFile();
     dataFile.delete();
     List<GenericData.Record> records = RandomData.generateList(SCHEMA, NUM_RECORDS, 0L);
     try (FileAppender<GenericData.Record> writer =

spark/v3.3/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetWritersFlatDataBenchmark.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.spark.data.parquet;
 
+import java.nio.file.Files;
 import static org.apache.iceberg.types.Types.NestedField.optional;
 import static org.apache.iceberg.types.Types.NestedField.required;
 
@@ -81,7 +82,7 @@ public class SparkParquetWritersFlatDataBenchmark {
   @Setup
   public void setupBenchmark() throws IOException {
     rows = RandomData.generateSpark(SCHEMA, NUM_RECORDS, 0L);
-    dataFile = File.createTempFile("parquet-flat-data-benchmark", ".parquet");
+    dataFile = Files.createTempFile("parquet-flat-data-benchmark", ".parquet").toFile();
     dataFile.delete();
   }
 

spark/v3.3/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetWritersNestedDataBenchmark.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.spark.data.parquet;
 
+import java.nio.file.Files;
 import static org.apache.iceberg.types.Types.NestedField.optional;
 import static org.apache.iceberg.types.Types.NestedField.required;
 
@@ -81,7 +82,7 @@ public class SparkParquetWritersNestedDataBenchmark {
   @Setup
   public void setupBenchmark() throws IOException {
     rows = RandomData.generateSpark(SCHEMA, NUM_RECORDS, 0L);
-    dataFile = File.createTempFile("parquet-nested-data-benchmark", ".parquet");
+    dataFile = Files.createTempFile("parquet-nested-data-benchmark", ".parquet").toFile();
     dataFile.delete();
   }
 

spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetReadersFlatDataBenchmark.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.spark.data.parquet;
 
+import java.nio.file.Files;
 import static org.apache.iceberg.types.Types.NestedField.optional;
 import static org.apache.iceberg.types.Types.NestedField.required;
 
@@ -93,7 +94,7 @@ public class SparkParquetReadersFlatDataBenchmark {
 
   @Setup
   public void setupBenchmark() throws IOException {
-    dataFile = File.createTempFile("parquet-flat-data-benchmark", ".parquet");
+    dataFile = Files.createTempFile("parquet-flat-data-benchmark", ".parquet").toFile();
     dataFile.delete();
     List<GenericData.Record> records = RandomData.generateList(SCHEMA, NUM_RECORDS, 0L);
     try (FileAppender<GenericData.Record> writer =

spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetReadersNestedDataBenchmark.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.spark.data.parquet;
 
+import java.nio.file.Files;
 import static org.apache.iceberg.types.Types.NestedField.optional;
 import static org.apache.iceberg.types.Types.NestedField.required;
 
@@ -91,7 +92,7 @@ public class SparkParquetReadersNestedDataBenchmark {
 
   @Setup
   public void setupBenchmark() throws IOException {
-    dataFile = File.createTempFile("parquet-nested-data-benchmark", ".parquet");
+    dataFile = Files.createTempFile("parquet-nested-data-benchmark", ".parquet").toFile();
     dataFile.delete();
     List<GenericData.Record> records = RandomData.generateList(SCHEMA, NUM_RECORDS, 0L);
     try (FileAppender<GenericData.Record> writer =

spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetWritersFlatDataBenchmark.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.spark.data.parquet;
 
+import java.nio.file.Files;
 import static org.apache.iceberg.types.Types.NestedField.optional;
 import static org.apache.iceberg.types.Types.NestedField.required;
 
@@ -81,7 +82,7 @@ public class SparkParquetWritersFlatDataBenchmark {
   @Setup
   public void setupBenchmark() throws IOException {
     rows = RandomData.generateSpark(SCHEMA, NUM_RECORDS, 0L);
-    dataFile = File.createTempFile("parquet-flat-data-benchmark", ".parquet");
+    dataFile = Files.createTempFile("parquet-flat-data-benchmark", ".parquet").toFile();
     dataFile.delete();
   }
 

spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetWritersNestedDataBenchmark.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.spark.data.parquet;
 
+import java.nio.file.Files;
 import static org.apache.iceberg.types.Types.NestedField.optional;
 import static org.apache.iceberg.types.Types.NestedField.required;
 
@@ -81,7 +82,7 @@ public class SparkParquetWritersNestedDataBenchmark {
   @Setup
   public void setupBenchmark() throws IOException {
     rows = RandomData.generateSpark(SCHEMA, NUM_RECORDS, 0L);
-    dataFile = File.createTempFile("parquet-nested-data-benchmark", ".parquet");
+    dataFile = Files.createTempFile("parquet-nested-data-benchmark", ".parquet").toFile();
     dataFile.delete();
   }
 

spark/v3.5/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetReadersFlatDataBenchmark.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.spark.data.parquet;
 
+import java.nio.file.Files;
 import static org.apache.iceberg.types.Types.NestedField.optional;
 import static org.apache.iceberg.types.Types.NestedField.required;
 
@@ -93,7 +94,7 @@ public class SparkParquetReadersFlatDataBenchmark {
 
   @Setup
   public void setupBenchmark() throws IOException {
-    dataFile = File.createTempFile("parquet-flat-data-benchmark", ".parquet");
+    dataFile = Files.createTempFile("parquet-flat-data-benchmark", ".parquet").toFile();
     dataFile.delete();
     List<GenericData.Record> records = RandomData.generateList(SCHEMA, NUM_RECORDS, 0L);
     try (FileAppender<GenericData.Record> writer =

spark/v3.5/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetReadersNestedDataBenchmark.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.spark.data.parquet;
 
+import java.nio.file.Files;
 import static org.apache.iceberg.types.Types.NestedField.optional;
 import static org.apache.iceberg.types.Types.NestedField.required;
 
@@ -91,7 +92,7 @@ public class SparkParquetReadersNestedDataBenchmark {
 
   @Setup
   public void setupBenchmark() throws IOException {
-    dataFile = File.createTempFile("parquet-nested-data-benchmark", ".parquet");
+    dataFile = Files.createTempFile("parquet-nested-data-benchmark", ".parquet").toFile();
     dataFile.delete();
     List<GenericData.Record> records = RandomData.generateList(SCHEMA, NUM_RECORDS, 0L);
     try (FileAppender<GenericData.Record> writer =

spark/v3.5/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetWritersFlatDataBenchmark.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.spark.data.parquet;
 
+import java.nio.file.Files;
 import static org.apache.iceberg.types.Types.NestedField.optional;
 import static org.apache.iceberg.types.Types.NestedField.required;
 
@@ -81,7 +82,7 @@ public class SparkParquetWritersFlatDataBenchmark {
   @Setup
   public void setupBenchmark() throws IOException {
     rows = RandomData.generateSpark(SCHEMA, NUM_RECORDS, 0L);
-    dataFile = File.createTempFile("parquet-flat-data-benchmark", ".parquet");
+    dataFile = Files.createTempFile("parquet-flat-data-benchmark", ".parquet").toFile();
     dataFile.delete();
   }
 

spark/v3.5/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetWritersNestedDataBenchmark.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.spark.data.parquet;
 
+import java.nio.file.Files;
 import static org.apache.iceberg.types.Types.NestedField.optional;
 import static org.apache.iceberg.types.Types.NestedField.required;
 
@@ -81,7 +82,7 @@ public class SparkParquetWritersNestedDataBenchmark {
   @Setup
   public void setupBenchmark() throws IOException {
     rows = RandomData.generateSpark(SCHEMA, NUM_RECORDS, 0L);
-    dataFile = File.createTempFile("parquet-nested-data-benchmark", ".parquet");
+    dataFile = Files.createTempFile("parquet-nested-data-benchmark", ".parquet").toFile();
     dataFile.delete();
   }