Front: Add front endpoint & swr to fetch tags from core #10565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdraier
approved these changes
Feb 6, 2025
| export const PostTagSearchBodySchema = t.type({ | ||
| query: t.string, | ||
| queryType: t.string, | ||
| dataSources: t.array(t.string), |
There was a problem hiding this comment.
Ideally here you should take an array of dataSourceViews instead (but can be fixed once core api is available)
There was a problem hiding this comment.
Yes I think I'll update when the endpoint is live as I'm likely gonna need to tweak things anyway!
PopDaph
force-pushed
the
front-search-tag-route
branch
from
de35c0f to
85b7de5
Compare
|
PopDaph
force-pushed
the
front-search-tag-route
branch
from
663d1ad to
9765246
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds:
coreApito fetch tags.POST /w/[wId]/data_sources/tags)Note: The new Core API route is blocked on #10441 and the request params will most likely change and not look like what I currently have now (
PostTagSearchBodySchema).But we can still merge this to continue working on the UI.
Tests
Tested locally.
Risk
Can be rolled back.
Deploy Plan
Deploy front.