Skip to content

Commit

Permalink
chore: deny dbg-macro in clippy (apache#983)
Browse files Browse the repository at this point in the history
## Rationale
`clippy::dbg-macro` lint default to allow in clippy, but we want it to
be denied.

## Detailed Changes
Add `-D clippy::dbg-macro` when running `cargo clippy`.

## Test Plan
Not need.
  • Loading branch information
Rachelint authored and dust1 committed Aug 9, 2023
1 parent ba4d76c commit 9f4a068
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ udeps:
cd $(DIR); cargo udeps --all-targets --all-features --workspace

clippy:
cd $(DIR); cargo clippy --all-targets --all-features --workspace -- -D warnings
cd $(DIR); cargo clippy --all-targets --all-features --workspace -- -D warnings -D clippy::dbg-macro

# test with address sanitizer
asan-test:
Expand Down
3 changes: 1 addition & 2 deletions components/message_queue/src/kafka/kafka_impl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,7 @@ impl KafkaImplInner {
panic!("The boost broker must be set");
}

let mut client_builder =
ClientBuilder::new(dbg!(config.client.boost_brokers.clone().unwrap()));
let mut client_builder = ClientBuilder::new(config.client.boost_brokers.clone().unwrap());
if let Some(max_message_size) = config.client.max_message_size {
client_builder = client_builder.max_message_size(max_message_size);
}
Expand Down

0 comments on commit 9f4a068

Please sign in to comment.