Cloud Push / Call Hilo API less often / Debounce color-wheel/brightness changes #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2023 08:33
Except for the gateway, it will come later once Hilo adds gateway infos to SignalR. Lowering polling frequency since we don't need to poll as much as we are getting data from pushes.
…hange / brightness change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rely less on entities.update() and more on SignalR data.
Even tho it's not used yet, manage device pairing and unpairing detection via SignalR.
In the future, we could use HA platform services to actually Add / Remove entities after detection instead of having to reload the integration.
Polling still happenning on Gateway, but lowered the frequency since it's not as crucial to have fresh Gateway Info
Debounce Color wheel changes, previously it was doing 3 api call for every new values, so if you drag across the wheel, it would send dozens of calls.
Depends on : dvd-dev/python-hilo#88