Repair windows wheels using delvewheel (in cibw build job) #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomir
force-pushed
the
fix/repair-windows-wheels/issue-870
branch
from
584792e to
9bf6008
Compare
`delvewheel` is not yet used by default for windows builds in CIBW (unlike delocate for macos, or auditwheel for linux), but official delvewheel shoutout was added to CIBW docs in pypa/cibuildwheel#650.
randomir
force-pushed
the
fix/repair-windows-wheels/issue-870
branch
from
9bf6008 to
78c6129
Compare
arcondello
approved these changes
Jul 11, 2022
|
I was going to wait until cibuildwheel officially supported it, but suppose there's no harm in getting ahead of it. |
|
Just realized I forgot to add reno. |
|
Right, I suppose this could/should have been in the changelog. IMO, probably fine to have missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delvewheelis not yet used by default for windows builds in CIBW (unlike delocate for macos, or auditwheel for linux), but officialdelvewheel shoutout was added to CIBW docs in pypa/cibuildwheel#650.
With
delocatealready used for macos CIBW builds, this PR closes #870.