Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Security Group Specification forces EC2 instance recreation #48

Closed
dwmkerr opened this issue May 1, 2018 · 0 comments · Fixed by #49
Closed

Incorrect Security Group Specification forces EC2 instance recreation #48

dwmkerr opened this issue May 1, 2018 · 0 comments · Fixed by #49

Comments

@dwmkerr
Copy link
Owner

dwmkerr commented May 1, 2018

Using security_groups instead of vpc_security_group_ids means that we need to recreate all EC2 instances unnecessarily when reapplying the infrastructure. See #27 for details:

#27 (comment)
@dwmkerr dwmkerr mentioned this issue May 1, 2018
Closed
dwmkerr added a commit that referenced this issue May 1, 2018
@dwmkerr
fix: corrected security group configuration
c320c0b 
this config avoids unnecessary recreation of the ec2 instances
when the cluster is updated. fixes #48.
@dwmkerr dwmkerr mentioned this issue May 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: corrected security group configuration dwmkerr/terraform-aws-openshift
1 participant
@dwmkerr