Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize npm build #67

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Optimize npm build #67

merged 1 commit into from
Jun 1, 2020

Conversation

havenchyk
Copy link

It doesn't make sense to deliver everything to the end user

It doesn't make sense to deliver everything to the end user
@dwmkerr
Copy link
Owner

dwmkerr commented Jun 1, 2020

Awesome, thanks so much! Makes it much cleaner this way 😄

@dwmkerr dwmkerr merged commit 2e7093c into dwmkerr:master Jun 1, 2020
@havenchyk havenchyk deleted the patch-1 branch June 1, 2020 10:07
@havenchyk
Copy link
Author

@dwmkerr it doesn't change a lot, but delivers less files so I feel it's more correct.

But I also noticed there is an opposite opinion like inspect-js/object-inspect#33 (review)

so please be aware of it as well 😄

but e.g. eslint doesn't follow this convention and uses "files" https://github.com/eslint/eslint/blob/master/package.json#L36-L43

@dwmkerr
Copy link
Owner

dwmkerr commented Jun 1, 2020

I agree - npm install should deliver the code required to use the package. If I want to run the tests, etc etc, I would clone and run them. So totally on board with this approach (frankly I think that this is much more correct this way as we don't pollute the consumer's node_modules with internal elements they shouldn't have to care about).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants