Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless notifications about founding of Hakland #77

Closed
rquinio opened this issue Jun 1, 2018 · 7 comments
Closed

Endless notifications about founding of Hakland #77

rquinio opened this issue Jun 1, 2018 · 7 comments

Comments

@rquinio
Copy link
Collaborator

rquinio commented Jun 1, 2018

This bug has been reported on steam by 2 persons and seems pretty annoying.
I don't more info though....

@terrydu
Copy link

terrydu commented Jun 10, 2018

The warning of warriors in the East, then the arrival of Haak, all worked correctly in my playthrough. Not sure if I ever got a notification about the founding of Hakland. Not sure how best to reproduce this. We might need to look at the code.

@TerryDuke
Copy link
Contributor

Right after posting that, I'm now able to reproduce it. It actually happens when the nomads settle. The realm of Hakland has existed for a while, but it seems at this point they change from no longer being nomads.

hakland-settled

I have a saved game file that I can share as well.

@TerryDuke
Copy link
Contributor

It seems that his government type doesn't change to Feudal.

The wording from the event ties back to this event notification:

# Informed about nomad settling as feudal
narrative_event = {
	id = HL.1
	title = EVTNAMEHL1
	desc = EVTDESCHL1
	
	picture = GFX_evt_steppe_mercenaries
	border = GFX_event_narrative_frame_diplomacy
	
	is_triggered_only = yes
	
	option = {
		name = EVTOPTA62911
	}
}

But I've noticed that the government type of Hakland doesn't change to Feudal. Also, on the world map you can see that Hakland's seat of government keeps changing location. So it appears that he keeps trying to settle, but doesn't become Feudal (or maybe something sets him back), and hence he tries to go Feudal again and settle down, but doesn't become Feudal... and the loop repeats.

@rquinio rquinio added this to the 0.9.1 milestone Jun 12, 2018
@rquinio
Copy link
Collaborator Author

rquinio commented Jun 12, 2018

Tried playing as Haakland after they win the nomad invasion - the settlement decision works and changes government.
I don't see the issue of capital changing location in my game, did 2.8.3 fix anything ?

@TerryDuke
Copy link
Contributor

Still happens in version 2.8.3.

I've attached a saved-game file.
Hen_Caerme1363_07_02-Hakland-Settled-Not-Compressed.zip

(It's 5MB, I can delete this after we've closed the issue if necessary.)

@terrydu
Copy link

terrydu commented Jun 13, 2018

Btw, just to clarify, it happens to me when I do not play as Hakland. In my case I'm playing as Duchess Francesca. I don't know what it's like if you actually play as Hakland. Either way, hopefully the saved game file will help figure out the specific repro steps.

rquinio added a commit that referenced this issue Jun 13, 2018

Unverified

This user has not yet uploaded their public signing key.
@rquinio
Copy link
Collaborator Author

rquinio commented Jun 13, 2018

Thanks for the save, I was able to narrowed it down: it was a bad merge with vanilla file change of government was only happening when ai=no !

@rquinio rquinio closed this as completed Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants