Password hash #65
Merged
Password hash #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #65 diff @@
===================================
Files 10 10
Lines 180 198 +18
Methods 39 42 +3
Messages 0 0
Branches 26 28 +2
===================================
+ Hits 180 198 +18
Misses 0 0
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR
Assumes password field exists when inserting new user data. Hashes the password field entry with bcrypt. #52
I feel #58 is a much better approach as this way to hardcoded for my liking and going against the flow of things but this is the MVP solution
Integration branch #64 has used the old solution.
Note the hashing on inserts has meant that promises aren't returned from db.insert so the cb method must be used here unless we want to promisify bcrypt.