Feedback table (rebased ✅)

[jackcarlisle]

ready for review

• adds feedback table + tests Feedback table (name tbc, see #18) #29
• adds pre-commit hook Pre-commit #31

[codecov-io]

Codecov Report

Merging #30 into master will decrease coverage by 11.11%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           master      #30       +/-   ##
===========================================
- Coverage     100%   88.88%   -11.12%     
===========================================
  Files           5        5               
  Lines          14        9        -5     
===========================================
- Hits           14        8        -6     
- Misses          0        1        +1

Impacted Files	Coverage Δ
web/models/feedback.ex	50% <50%> (ø)
web/models/user.ex

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc0bfb...ff89b8e. Read the comment docs.

[jackcarlisle]

@nelsonic my test coverage locally is 100%. The remote test coverage was 100% before the rebase as well but it's gone down to 87.5% now. Looking into why this is the case.

[nelsonic]

@jackcarlisle please assign for review when you think it's ready. 😉
I want to approve your timesheet/invoice but need to clear down the PR backlog first. 👍

[jackcarlisle]

@nelsonic I've been looking into why the coverage has dropped and I think it will get back up to 100% after the next PR is merged. It's got something to do with not having any feedback controller tests which means that the model isn't hit. I think the next PR will solve this though so I'm going to assign this as ready

[nelsonic]

@jackcarlisle do you want to add .env to .gitignore and reset the AWS secrets (ASAP) then re-assign to me for merging?

[jackcarlisle]

@nelsonic yeah sorry just saw that!

[jackcarlisle]

@nelsonic secrets changed, ignored and deleted from AWS

[nelsonic]

@jackcarlisle cool. thanks for confirming. merging now. 👍
https://vimeo.com/50600813