Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation #48

Closed
wants to merge 29 commits into from
Closed

Navigation #48

wants to merge 29 commits into from

Conversation

jackcarlisle
Copy link
Member

ready for review after #46 (needs rebase)

  • adds navigation bar and navigation links

#47

@codecov-io
Copy link

codecov-io commented Apr 13, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@5a68388). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #48   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     12           
  Lines             ?    133           
  Branches          ?      0           
=======================================
  Hits              ?    133           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
test/support/conn_case.ex 100% <ø> (ø)
web/router.ex 100% <ø> (ø)
web/models/feedback.ex 100% <100%> (ø)
web/controllers/session_controller.ex 100% <100%> (ø)
test/support/test_helpers.ex 100% <100%> (ø)
web/controllers/page_controller.ex 100% <100%> (ø)
web/channels/room_channel.ex 100% <100%> (ø)
web/controllers/feedback_controller.ex 100% <100%> (ø)
web/controllers/auth.ex 100% <100%> (ø)
web/models/user.ex 100% <100%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a68388...2f135fb. Read the comment docs.

@jackcarlisle jackcarlisle changed the title Navbar Navigation Apr 13, 2017
@jackcarlisle jackcarlisle mentioned this pull request Apr 14, 2017
2 tasks
@jackcarlisle
Copy link
Member Author

Closing due to changes in the db that are effecting tests, thus previous branches can't be merged

@jackcarlisle jackcarlisle deleted the navbar branch May 10, 2017 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants