Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Petal components section #21

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Add Petal components section #21

merged 2 commits into from
Oct 4, 2022

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Oct 4, 2022

Add reference on how to add Petal to Phoenix

Add reference on how to add Petal to Phoenix
@SimonLab SimonLab force-pushed the petal-components-#20 branch from a79fe21 to da54767 Compare October 4, 2022 09:59
@nelsonic nelsonic added the in-progress An issue or pull request that is being worked on by the assigned person label Oct 4, 2022
Latest Phoenix.LiveView version requires Phoenix.Component module
to be imported for some view helper function to be found
@SimonLab SimonLab requested a review from nelsonic October 4, 2022 10:17
@SimonLab SimonLab added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #21 (9c1f999) into main (753a5d3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines            4         4           
=========================================
  Hits             4         4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab thanks for adding. 👍

@nelsonic nelsonic merged commit e26ab6a into main Oct 4, 2022
@nelsonic nelsonic deleted the petal-components-#20 branch October 4, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants