Check for success before clearing form. #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @tarasyarema for discovering the fix for this. Originally pulled from PR #315. Makes sure that the XHR request is completed and successful before clearing and hiding the form.
Cleans up console output. Manual logging can be added by users themselves as desired.
Removed as part of another PR, but I forgot to remove the unused function. It just checks if there is a value and returns the result of that if statement, with unnecessary logging, so clean that all up.
mckennapsean
force-pushed
the
check-for-success
branch
from
aa88589 to
0130608
Compare
|
Addressed the merge conflicts, and did some code cleanup in the last two commits (removed another console log statement, and removed a function no longer used). |
nelsonic
reviewed
Aug 26, 2019
| var thankYouMessage = form.querySelector(".thankyou_message"); | ||
| if (thankYouMessage) { | ||
| thankYouMessage.style.display = "block"; | ||
| if (xhr.readyState === 4 && xhr.status === 200) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on work from #315 to get the changes we can use onto master.