Remove unnecessary form validation for email #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTML 5 form input type of email already handles email validation. There are cases that are allowed by HTML5 (e.g., "a@a") which our form used to detect and notify the user. Since these are less likely to happen, and the logic is still not fool-proof, simplify the code and assumptions made therein to be more generalizable and thus more robust. This is supported in all modern browsers, and I tested this also in Edge to verify that it works there, too. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/email
nelsonic
approved these changes
May 27, 2019
There was a problem hiding this comment.
@mckennapsean agreed. this can/should be simplified. thanks for removing. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTML 5 form input type of email already handles
email validation. There are cases that are allowed by
HTML5 (e.g., "a@a") which our form used to detect
and notify the user. Since these are less likely to
happen, and the logic is still not fool-proof, simplify
the code and assumptions made therein to be
more generalizable and thus more robust. This is
supported in all modern browsers, and I tested
this also in Edge to verify that it works there, too.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/email