Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language-change part in the README files #356

Merged
merged 3 commits into from
Jan 23, 2020
Merged

Conversation

GimunLee
Copy link
Contributor

When I saw README file of this repository, I thought it would be better it have language-change part(English, Korean, Spanish). So, I have added it

If you don't agree with my idea, just close this. 😃

Add translation link
Spanish -> Español
Add translation link
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GimunLee good idea. 💡
laguage-change
really wish there was a way of keeping this updated automatically ... 💭

@mckennapsean
Copy link
Collaborator

mckennapsean commented Jan 23, 2020

really wish there was a way of keeping this updated automatically ... 💭

See #329

Still have concerns around #271 - unless we have a maintainer able to hop on every PR for the main readme to do a manual translation (or some other way to outsource it), then the new translated readmes may get out of date. Alternative: never change the readme or code significantly :)

@mckennapsean mckennapsean self-requested a review January 23, 2020 08:15
@mckennapsean mckennapsean removed their assignment Jan 23, 2020
Copy link
Collaborator

@mckennapsean mckennapsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Long-term still unsure how I feel with having translated readmes in here, but I appreciate having an up-to-date translated readme so wouldn't say no :-) Thanks for this improvement as well!

nit: we could add links from Spanish back to these, though the Spanish one is just a placeholder with a warning, so not necessary in my opinion.

@nelsonic
Copy link
Member

@mckennapsean yeah, agree with everything you've written above. 👍
I feel that this tutorial is pretty "stable" now so don't expect too many changes in the near future. 💭

@nelsonic nelsonic merged commit 798c074 into dwyl:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants