Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add portuguese translation #391

Merged
merged 2 commits into from
Nov 1, 2020
Merged

Add portuguese translation #391

merged 2 commits into from
Nov 1, 2020

Conversation

cristianofromagio
Copy link
Contributor

Had some fun lately with Google Apps Script thanks to this amazing project for introducing it to me.

Hope for this project to reach more people, so here we go!

@iteles
Copy link
Member

iteles commented Nov 1, 2020

@cristianofromagio Thank you for contributing this! 👀

@mckennapsean @nelsonic I'm happy to review this one today, will get to it before the end of the day 👍

@iteles iteles self-assigned this Nov 1, 2020
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cristianofromagio thanks for taking the time to create this PR! 🚀
@iteles yeah, happy for you to review+merge given your fluency in PT. 👍

iteles
iteles previously approved these changes Nov 1, 2020
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great translation, thank you @cristianofromagio !!

@nelsonic I've added a couple of very minor suggested changes - could you please review/merge? Thanks!

@@ -1,6 +1,6 @@
# Google Apps Mail을 사용해 **정적** HTML Form에서 메일을 보내세요!

**Language : [English](https://github.com/dwyl/learn-to-send-email-via-google-script-html-no-server#send-email-from-a-static-html-form-using-google-apps-mail) | `한국어` | [Español](https://github.com/dwyl/learn-to-send-email-via-google-script-html-no-server/blob/master/README.es.md#older-translation)**
**Language : [English](https://github.com/dwyl/learn-to-send-email-via-google-script-html-no-server#send-email-from-a-static-html-form-using-google-apps-mail) | `한국어` | [Español](https://github.com/dwyl/learn-to-send-email-via-google-script-html-no-server/blob/master/README.es.md#older-translation) | [Português](https://github.com/dwyl/learn-to-send-email-via-google-script-html-no-server/blob/master/README.pt.md)**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tempted to remove these links from the translated versions altogether to decrease maintenance seeing as they're already in the main readme which is what matters, but let's open an issue on it and deal with that separately! 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I think we should remove them in a separate (future) PR. 👍

# Envie e-mail a partir de um formulário HTML *estático* usando o Google Apps Mail!

**Language : [English](https://github.com/dwyl/learn-to-send-email-via-google-script-html-no-server/blob/master/README.md) | [한국어](https://github.com/dwyl/learn-to-send-email-via-google-script-html-no-server/blob/master/README.ko.md#google-apps-mail을-사용해-정적-html-form에서-메일을-보내세요) | [Español](https://github.com/dwyl/learn-to-send-email-via-google-script-html-no-server/blob/master/README.es.md#older-translation) | `Português`**

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, I feel that each readme should really have a disclaimer at the top with the latest commit to which it was updated (in this case https://github.com/dwyl/learn-to-send-email-via-google-script-html-no-server/tree/ce8152ff90260cac8b2bff36cbe91bb29a80447f) for maintenance clarity. Another one for a separate issue! 👍

README.pt.md Show resolved Hide resolved
README.pt.md Outdated Show resolved Hide resolved
README.pt.md Outdated Show resolved Hide resolved
### 4. Salve uma *nova versão* do seu Script

Não é imediatamente *óbvio* mas você deve *clicar* em "**Arquivo**" > "**Gerenciar versões...**"
**_Nota de tradução:_** pode ser que a interface em `https://script.google.com/` não esteja traduzida, mesmo se seu idioma esteja definido como Português por padrão, o caminho para salvar a nova versão então seria (em inglês): "**File**" > "**Manage versions...**"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I said above, I tried to follow the steps and match the labels on my (portuguese) interface. But just couldn't get https://script.google.com to display on portuguese (or any other than the english default), so I translated as it appeared on similar pages and kept the original on the translator’s note (more like a "translation's note" but you know what I mean 🤣).

README.pt.md Outdated Show resolved Hide resolved
README.pt.md Outdated Show resolved Hide resolved
README.pt.md Show resolved Hide resolved
README.pt.md Outdated Show resolved Hide resolved
@iteles iteles assigned nelsonic and unassigned iteles Nov 1, 2020
Co-authored-by: Ines Teles Correia <[email protected]>
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cristianofromagio thanks again for this superb PR. 🎉
I'm sure a lot of people will find it useful. 🇧🇷 + 🇵🇹 + 🇲🇿, etc. 👍
@iteles thanks for the extended review and updates. 👩‍💻 ❤️

@nelsonic nelsonic merged commit d4c8902 into dwyl:master Nov 1, 2020
@cristianofromagio
Copy link
Contributor Author

Thanks @nelsonic with the technicalities and really thank you @iteles for the thoughtful review!
And thanks you all for creating @dwyl and making it this one-of-a-kind learning place.

Would feel really honored if you could label this PR hacktoberfest-accepted if you feel it is worth it! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants