-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Improve Stats Page #397
Comments
hey! :) Can I take this one? Or it needs more refinement? Please, point me to a |
Personally, I think you can get on with it. This issue and #396 seem to be plausible for @panoramix360 to develop. Since we are using Tailwind and have a license/access to https://tailwindui.com/, if you find any of their components suitable, you can comment on the PR and we'll drop the code in it on your request so you can work on it, if you want 😄 |
Indeed. I opened several issue in response to the superb feedback given by @panoramix360 on: #140 (comment) 💬 |
I'll work on it then! Just assigned it to me if that's not a problem. |
Awesome. Thanks. If you need access to |
I was looking through the components in Tailwind UI and it seems they already have the sortable headings: Do we have access to it on the paid subscription? I want to send you an email to get access if possible, but I didn't understand your last message hehe |
Yes, we do :) You need a license to get the code of those components, which was what @nelsonic was trying to say in #397 (comment). If you give him an e-mail, he'll get you on with it.
In this So, our "first joined" assumption, although interesting, is not entirely accurate because they didn't necessarily join whenever they created the first item. However, because you don't really have access to this kind of information, I think it's a fair implementation (@nelsonic can correct me on this).
Currently, the total timers (meaning the amount of Again, thanks a lot for being proactive, it's wholeheartedly appreciated! If I'm wrong on anything that I've said here, @nelsonic will promptly correct me 👌 |
hey! thank you @LuchoTurtle My email is Regarding the We can also create a About the timers, I figure it would be something like this then: I'll format the time correctly, I'm showing in seconds, but we can show in minutes. But I wanted to show you the progress. It's nice to contribute, I hope to contribute to other projects as well, especially the ones about learning. I was a professor at a University in the past (I teach Swift/iOS and React Native :D), so I really like this education focus that you guys are doing. I'll wait for @nelsonic thoughts as well, but thank you for that :) |
Hi @panoramix360, thanks for following up. All/always good questions. ❤️ As @LuchoTurtle says, our goal is to store zero personally identifiable information in the As Lucho has said, the the "total timers" is the amount of time as opposed to the All contributions are very welcome. If you create a We are huge fans of sharing all of our learning so that anyone can follow along regardless of where/who they are. Yes, even if that means we are "training" |
hey! Thank you for the TailwindUI access, I'll begin the implementation of the sorted columns :) Understood and agreed about storing zero info on the Thank you for the clarification of the elapsed time! I implemented that already, I'll show it in the following format Nice! I created a branch inside MVP for this current issue, I'll take a look at the other projects as well later :) I'm seeing that you guys are creating some projects about Flutter, this interests me as well, I know a lot about the Mobile env like Android/iOS and even React Native, so it can be something that I can contribute. Good know about sharing our learning, I really like that too!!! |
Good shout on using Line 63 in 4a04f86
So definitely use it. ✅ |
Derp. didn't mean to close it. Some how clicked the wrong button. 🤦♂️ |
hey! I'm finishing the sorting mechanism and it's looking great! I decided to create a Table LiveComponent that can be used in other places on the application as well! I hope that you guys like the idea/code. It's my first iteration of creating a LiveComponent so it was nice to learn. So I extracted the template and files to a separate place that can be reused. And the sorting will be triggered when a column is clicked passing the sorting column as a LiveView event for the metrics to be sorted out. I need more data to test this sorting on the database, but I can't log in locally, is there something that I need to do related to the AuthPlug to run this? Or is not possible to run locally? |
Awesome! Can you expand on why you can't log in? Maybe you don't have the env variables properly set. Give https://github.com/dwyl/auth_plug#2-get-your-auth_api_key- a read, it might help you. However, if you really just want to test if the sorting works, maybe it's simpler to just create an array in the socket assigns with mock data and show it on the view and see if everything works. 💭 |
hey @LuchoTurtle :D I was doing that (the mocking thing) but in regards to the sorting, this doesn't work, the sorting is being done on the Ecto/Database layer. I'll take a look at the link that you sent. In the meantime, I'll try to generate fake data on the database as well. |
Do you know if the |
It's not :P In practicality, you'll probably only need to change the To get your own After these, if you run locally, you should have auth properly working on your local project :) |
I managed to add items by hand to the database to make some tests. I'll look into the auth later :) The sorting is working :D I just need to create the Tailwind look now on the columns. |
@panoramix360 if you push a branch and open a PR we can help with any parts you don't have time for. 👌 |
Done! I opened a PR #399 so you guys can already review the code. The only things missing are:
|
Thanks again @panoramix360 🎉 |
Closing this since it's been completed 🥳 |
At present the
/stats
page is quite basic: https://mvp.fly.dev/statsWe can add a lot more info/insight to this page.
Todo
person
first joined (for authenticatedpeople
)timers
- the total amount of elapsed time the person has logged usingtimers
in theMVP
.item
date (item.created_at
)person
viewing the/stats
page; make it personal to them.The text was updated successfully, but these errors were encountered: