fix: Timer starting from 00:00:00 #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th0mas
force-pushed
the
th0mas/timer-start-fix
branch
from
19bd946 to
b9ed35d
Compare
|
Looks like tests are failing on auth errors :( |
nelsonic
added
the
awaiting-review
nelsonic
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for the timer starting from 00:00:00 on restart. There might be a nicer way to tidy this code up - I'm not well versed in AlpineJS though.
Let me know if you want to create an issue to track this - I just noticed when playing around and thought it would be easiest to submit a PR 😃
Screen.Recording.2024-03-12.at.00.23.45.mov