Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates #152

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Updates #152

merged 7 commits into from
Feb 8, 2024

Conversation

SimonLab
Copy link
Member

see #151 and #150

SimonLab added 2 commits July 26, 2023 11:23
Run `mix format`
- Add tailwind using the Elixir tailwind dependency
- Use esbuild to manage tailwind css classes
see https://tailwindcss.com/docs/guides/phoenix

ref: #151
@SimonLab SimonLab added the in-progress An issue or pull request that is being worked on by the assigned person label Jul 26, 2023
@SimonLab SimonLab self-assigned this Jul 26, 2023
@SimonLab SimonLab temporarily deployed to liveview-chat-example July 26, 2023 10:52 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2456be4) 100.00% compared to head (64aa412) 100.00%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #152   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           51        51           
=========================================
  Hits            51        51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Because we have already a login button on the header
we can make the footer a bit lighter by removing the duplicate login
button
@SimonLab SimonLab temporarily deployed to liveview-chat-example July 26, 2023 11:08 — with GitHub Actions Inactive
Use :text instead of :string to allow long text as message
see: #149
@SimonLab SimonLab temporarily deployed to liveview-chat-example July 26, 2023 11:22 — with GitHub Actions Inactive
@nelsonic
Copy link
Member

Updates looking good so far. 👌

@nelsonic nelsonic assigned nelsonic and unassigned SimonLab Feb 7, 2024
@nelsonic
Copy link
Member

nelsonic commented Feb 8, 2024

Getting the following warning when running this branch on localhost:

You have configured application :tailwind in your configuration file,
but the application is not available.

This usually means one of:

  1. You have not added the application as a dependency in a mix.exs file.

  2. You are configuring an application that does not really exist.

Please ensure :tailwind exists or remove the configuration.

@nelsonic nelsonic had a problem deploying to liveview-chat-example February 8, 2024 15:20 — with GitHub Actions Failure
@nelsonic nelsonic temporarily deployed to liveview-chat-example February 8, 2024 15:34 — with GitHub Actions Inactive
@nelsonic
Copy link
Member

nelsonic commented Feb 8, 2024

Branch auto-deployed to: https://liveview-chat-example.fly.dev/

Still working fine including auth:
image

Don't think there's anything else to add here.

@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Feb 8, 2024
@nelsonic nelsonic self-requested a review February 8, 2024 15:40
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look great. Thanks again @SimonLab 👌

@nelsonic nelsonic merged commit 6a8e603 into main Feb 8, 2024
3 checks passed
@nelsonic nelsonic deleted the updates branch February 8, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants