Replace crypto lib ecdsa with coincurve #312
Open
+338
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnowosie
force-pushed
the
pnowosie/replace-ecdsa
branch
2 times, most recently
from
5b55752 to
cfe0efb
Compare
pnowosie
force-pushed
the
pnowosie/replace-ecdsa
branch
from
cfe0efb to
5b89330
Compare
ttl33
reviewed
Jan 14, 2025
v4-client-py-v2/pyproject.toml
Outdated
| @@ -28,6 +28,7 @@ pytest-asyncio = "^0.23.6" | |||
| python-dotenv = "^1.0.1" | |||
| twine = "^4.0.2" | |||
| black = "^24.4.0" | |||
| ecdsa = "^0.19.0" | |||
There was a problem hiding this comment.
is there a way to remove this dependency entirely?
There was a problem hiding this comment.
Definitelly 👍 It's removed in c9d92f1
For clarity ecdsa is no longer direct dependency but still will be pulled as bip-utils depends of it.
Based on Snyk Advisor, bip-utils does not have these vulnerabilities and is considered secure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
ecdsawithcoincurvefor crypto signingecdsa, being a pure Python implementation, is vulnerable to side-channel attacks