Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes when selecting different station #14

Closed
fox365 opened this issue Jul 29, 2012 · 6 comments
Closed

Crashes when selecting different station #14

fox365 opened this issue Jul 29, 2012 · 6 comments

Comments

@fox365
Copy link

fox365 commented Jul 29, 2012

When playing a station and go to menu - stations - "different station" app force closes

Droid Razr ics

@dylanPowers
Copy link
Owner

Hmm, you're going to have to be more specific, but I have a guess that this occurred under suboptimal network conditions? Either way, the station activity needs to be rewritten as it's screwed up in so many ways ;), but thanks for the bug report!

@fox365
Copy link
Author

fox365 commented Jul 30, 2012

Nope, full lte it loads the song super fast but switching stations instantly kills pandoroid an easy bug to get used to

@dylanPowers
Copy link
Owner

And you're on my latest preview release right? because I can't duplicate this. A LogCat would be nice if you could get one, otherwise we could wait and see if a proper implementation of the station selection will do the trick.

@dylanPowers
Copy link
Owner

Well, I did some investigating, and was able to finally recreate this error. It appears to have something to do with my MediaPlayer implementation. I'm not 100% sure, but it appears to only occur if the switch happens before a cached song has started downloading (or maybe when no songs are downloading? or just the main song)
56:20.885 E/AndroidRuntime(20151): FATAL EXCEPTION: Thread-891
08-01 21:56:20.885 E/AndroidRuntime(20151): java.lang.IllegalStateException
08-01 21:56:20.885 E/AndroidRuntime(20151): at android.media.MediaPlayer.getDuration(Native Method)
08-01 21:56:20.885 E/AndroidRuntime(20151): at com.pandoroid.playback.ConcurrentSongMediaPlayer.getDuration(ConcurrentSongMediaPlayer.java:90)
08-01 21:56:20.885 E/AndroidRuntime(20151): at com.pandoroid.playback.MediaPlaybackController.run(MediaPlaybackController.java:129)
08-01 21:56:20.885 E/AndroidRuntime(20151): at java.lang.Thread.run(Thread.java:856)
08-01 21:56:20.890 W/ActivityManager( 1923): Force finishing activity com.pandoroid/.PandoroidPlayer

@dylanPowers
Copy link
Owner

This will be included when I release my next preview.

@fox365
Copy link
Author

fox365 commented Aug 12, 2012

It hasn't been crashing lately even with the same version I made a logcat but it looks like I don't need to send it if it is fixed in the current version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants