BUGFIX Call to a member function Categories() on null

Resolves an issue where no blog selected causes a chained `Categories()` relation call to error when attempting to edit the block later in the cms.
dynamic · Aug 26, 2022 · c1ad497 · c1ad497
1 parent c6f4adf
commit c1ad497
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/src/Elements/ElementBlogPosts.php b/src/Elements/ElementBlogPosts.php
@@ -43,25 +43,25 @@ class ElementBlogPosts extends BaseElement
     /**
      * @var array
      */
-    private static $db = array(
+    private static $db = [
         'Limit' => 'Int',
         'Content' => 'HTMLText',
-    );
+    ];
 
     /**
      * @var array
      */
-    private static $has_one = array(
+    private static $has_one = [
         'Blog' => Blog::class,
         'Category' => BlogCategory::class,
-    );
+    ];
 
     /**
      * @var array
      */
-    private static $defaults = array(
+    private static $defaults = [
         'Limit' => 3,
-    );
+    ];
 
     /**
      * @return FieldList
@@ -85,7 +85,10 @@ public function getCMSFields()
 
                 $dataSource = function ($val) {
                     if ($val) {
-                        return Blog::get()->byID($val)->Categories()->map('ID', 'Title');
+                        if ($blog = Blog::get()->byID($val)) {
+                            return $blog->Categories()->map('ID', 'Title');
+                        }
+
                     }
                     return [];
                 };
@@ -137,7 +140,7 @@ public function getSummary()
         $label = _t(
             BlogPost::class . '.PLURALS',
             'A Blog Post|{count} Blog Posts',
-            [ 'count' => $count ]
+            ['count' => $count]
         );
         return DBField::create_field('HTMLText', $label)->Summary(20);
     }