Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial i18n implementation #15

Merged
merged 1 commit into from
Jun 4, 2019
Merged

initial i18n implementation #15

merged 1 commit into from
Jun 4, 2019

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Jun 4, 2019

fixes #13

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #15 into master will increase coverage by 6.3%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #15     +/-   ##
===========================================
+ Coverage     62.71%   69.01%   +6.3%     
- Complexity       19       21      +2     
===========================================
  Files             2        2             
  Lines            59       71     +12     
===========================================
+ Hits             37       49     +12     
  Misses           22       22
Flag Coverage Δ Complexity Δ
#php 69.01% <100%> (+6.3%) 21 <2> (+2) ⬆️
Impacted Files Coverage Δ Complexity Δ
src/Elements/ElementFileList.php 53.12% <100%> (+6.69%) 8 <1> (+1) ⬆️
src/Model/FileListObject.php 82.05% <100%> (+4.63%) 13 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f69618...c94ab1a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 4, 2019 •
edited
Loading

Codecov Report

Merging #15 into master will increase coverage by 6.3%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #15     +/-   ##
===========================================
+ Coverage     62.71%   69.01%   +6.3%     
- Complexity       19       21      +2     
===========================================
  Files             2        2             
  Lines            59       71     +12     
===========================================
+ Hits             37       49     +12     
  Misses           22       22
Flag Coverage Δ Complexity Δ
#php 69.01% <100%> (+6.3%) 21 <2> (+2) ⬆️
Impacted Files Coverage Δ Complexity Δ
src/Elements/ElementFileList.php 53.12% <100%> (+6.69%) 8 <1> (+1) ⬆️
src/Model/FileListObject.php 82.05% <100%> (+4.63%) 13 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f69618...c94ab1a. Read the comment docs.

@jsirish jsirish merged commit 7220181 into dynamic:master Jun 4, 2019
@jsirish jsirish deleted the feature/i18n branch June 4, 2019 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

initial i18n support
1 participant
@jsirish