Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix - set folder name for File field #17

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Jun 4, 2019

fixes #16

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #17 into master will increase coverage by 0.43%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #17      +/-   ##
============================================
+ Coverage     69.01%   69.44%   +0.43%     
  Complexity       21       21              
============================================
  Files             2        2              
  Lines            71       72       +1     
============================================
+ Hits             49       50       +1     
  Misses           22       22
Flag Coverage Δ Complexity Δ
#php 69.44% <66.66%> (+0.43%) 21 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
src/Elements/ElementFileList.php 53.12% <0%> (ø) 8 <0> (ø) ⬇️
src/Model/FileListObject.php 82.5% <100%> (+0.44%) 13 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7220181...533eb08. Read the comment docs.

@jsirish jsirish merged commit 9830f75 into dynamic:master Jun 4, 2019
@jsirish jsirish deleted the bugfix/folderName branch June 4, 2019 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG - set FolderName for File field
1 participant