Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlexSlider - enable Thumbnail navigation #85

Merged
merged 1 commit into from
Mar 1, 2017
Merged

FlexSlider - enable Thumbnail navigation #85

merged 1 commit into from
Mar 1, 2017

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Mar 1, 2017

closes #1

@jsirish
Copy link
Member Author

jsirish commented Mar 1, 2017

closes #83

@codecov
Copy link

codecov bot commented Mar 1, 2017

Codecov Report

Merging #85 into 1.0 will increase coverage by 0.14%.
The diff coverage is 59.25%.

@@            Coverage Diff             @@
##              1.0      #85      +/-   ##
==========================================
+ Coverage   69.42%   69.56%   +0.14%     
==========================================
  Files           2        2              
  Lines         121      161      +40     
==========================================
+ Hits           84      112      +28     
- Misses         37       49      +12
Impacted Files Coverage Δ
code/FlexSlider.php 56.63% <59.25%> (+7.32%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cd6829...3ba122b. Read the comment docs.

@jsirish jsirish requested a review from muskie9 March 1, 2017 13:28
@jsirish
Copy link
Member Author

jsirish commented Mar 1, 2017

@muskie9 this should be ready to go. Ran into an issue with adding all the new config options in CMS where existing installs with thumbnails will be wonky without the three carousel thumbnail settings. To fix, added populate defaults, an onBeforeWrite to set defaults if empty, and a task to set the "new" defaults on existing FlexSlider instances.

Might be overkill since there are no existing installations with thumbnails, but thought I'd point it out

@jsirish jsirish merged commit 25e010b into dynamic:1.0 Mar 1, 2017
@jsirish jsirish deleted the feature/thumbnailNav branch March 1, 2017 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant