-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: #414 remove user warning suppression #528
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
=======================================
Coverage 94.05% 94.05%
=======================================
Files 38 38
Lines 4157 4157
=======================================
Hits 3910 3910
Misses 247 247 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for investigating! On a related note, can we clear the pysindy
import warning:
>>> import pysindy
/home/jake/github/pysindy/pysindy/__init__.py:1: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
We should be able to get __version__
from the pysindy.version
module that setuptools_scm makes.
We can use python built-in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use python built-in importlib.metadata lib which is recommended by setuptools. Would that be better?
LGTM! Yes, good point! If we swap out setuptools_scm, this code would have to change. Whereas using python's metadata record is more reliable.
Just fix the linting and I'll merge this
Fix #414, remove user warning suppression from pysindy.
The side effect of this PR is the number of warnings in the test files will increase from 139 to 533.
Most warnings are from
StableLinearSR3
andTrappingSR3
optimizers throwing warnings if given default parameters.