Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN(pde_library): remove unused constructor argument #537

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

himkwtn
Copy link
Collaborator

@himkwtn himkwtn commented Jul 25, 2024

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.05%. Comparing base (15e8093) to head (9ebe6cf).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #537      +/-   ##
==========================================
- Coverage   94.05%   94.05%   -0.01%     
==========================================
  Files          38       38              
  Lines        4158     4157       -1     
==========================================
- Hits         3911     3910       -1     
  Misses        247      247              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jacob-Stevens-Haas Jacob-Stevens-Haas linked an issue Jul 29, 2024 that may be closed by this pull request
Copy link
Member

@Jacob-Stevens-Haas Jacob-Stevens-Haas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also do this for WeakPDELibrary?

Copy link
Member

@Jacob-Stevens-Haas Jacob-Stevens-Haas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! I'll merge it when it passes CI (except of course docs)

@Jacob-Stevens-Haas Jacob-Stevens-Haas merged commit 90464db into master Jul 29, 2024
4 of 5 checks passed
@Jacob-Stevens-Haas Jacob-Stevens-Haas deleted the CLN-492 branch July 29, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Remove interaction_only arg from PDELibrary
2 participants