Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARM Syntax] Should print zero immediate for compares #237

Closed
nathanhjay opened this issue Nov 15, 2016 · 1 comment
Closed

[ARM Syntax] Should print zero immediate for compares #237

nathanhjay opened this issue Nov 15, 2016 · 1 comment
Assignees
@ssunny7
Labels
bug
Milestone
ARM decoding cleanup

Comments

@nathanhjay
Copy link
Contributor

When comparing with zero either for floating point or integer, we should be printing the immediate.

Bytes: 10 aa e0 5e
Output: cmlt d16, d16
Expected Output: cmlt d16, d16, #0

Bytes: 10 ca e0 5e
Output: fcmgt d16, d16
Expected Output: fcmgt d16, d16, #0.0
@wrwilliams wrwilliams added the bug label Feb 9, 2017
@wrwilliams wrwilliams modified the milestone: ARM decoding cleanup Mar 14, 2017
ssunny7 added a commit that referenced this issue May 3, 2017
@ssunny7
Issues #237 (Should print zero immediate for compares)
5e63e68 
Zero variants of some SIMD/FP compare instructions as well as a few other instructions in the SIMD 2-register miscellaneous category should have a zero operand.
@ssunny7
Copy link
Contributor

ssunny7 commented May 3, 2017

Fixed by 5e63e68.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssunny7 ssunny7

Labels
bug
Projects
None yet
Milestone
ARM decoding cleanup
Development

No branches or pull requests
4 participants
@sashanicolas @wrwilliams @nathanhjay @ssunny7