Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hook configuration #17

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Add pre-commit hook configuration #17

merged 2 commits into from
Jul 19, 2022

Conversation

Jackenmen
Copy link
Contributor

Adds support for usage with pre-commit

@CagtayFabry
Copy link

would be really nice to have this, can you take a look @dzhu ?

@dzhu dzhu merged commit 5858e40 into dzhu:master Jul 19, 2022
dzhu pushed a commit that referenced this pull request Jul 19, 2022
@Jackenmen Jackenmen deleted the patch-1 branch July 19, 2022 01:49
@onemec
Copy link

onemec commented Nov 1, 2022

@jack1142 would it be possible to push out a new release/tag so that this is usable with pre-commit? Right now, I've been able to get it working by tagging the commit SHA, but the latest release doesn't have it yet.

Also, minor suggestion, but might be nice to add a blurb to the README with an example pre-commit config similar to:

 - repo: https://github.com/dzhu/rstfmt
    rev: de1ae7823e3242402a68202fcb7dee9b2ee17ce7 <--- hoping to replace this with v0.0.12
    hooks:
      - id: rstfmt

and/or adding a .pre-commit-config.yaml similar to Black's example.
Happy to help with this as well, and appreciate the project!

@Jackenmen
Copy link
Contributor Author

I'm not the project owner.

@onemec
Copy link

onemec commented Nov 2, 2022

Ah sorry I meant to tag @dzhu, sorry for the ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants