Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

fix(utils): set workingDirectory to NX_WORKSPACE_ROOT_PATH env var #59

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

ronnetzer
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

workingDirectory input is not affecting NX

Issue Number: fixes #56

What is the new behavior?

NX_WORKSPACE_ROOT_PATH env variable will be set with the input's value

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #59 (61d3a12) into main (cbbf3e8) will decrease coverage by 0.23%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   87.92%   87.69%   -0.24%     
==========================================
  Files          15       15              
  Lines         381      382       +1     
  Branches       55       55              
==========================================
  Hits          335      335              
- Misses         43       44       +1     
  Partials        3        3              
Flag Coverage Δ
nx-affected-matrix 95.91% <ø> (ø)
nx-distributed-task 100.00% <ø> (ø)
utils 80.34% <0.00%> (-0.36%) ⬇️
Impacted Files Coverage Δ
packages/utils/src/lib/inputs.ts 57.37% <0.00%> (-0.96%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ronnetzer ronnetzer merged commit 78f356d into main Nov 22, 2022
@ronnetzer ronnetzer deleted the bugfix/workdir-not-working branch November 22, 2022 08:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Without NX_WORKSPACE_ROOT_PATH I got an error about missing nx.json file.
1 participant